Add TPM2_PolicySigned and Signature encoding #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmwu
force-pushed
the
policySigned
branch
3 times, most recently
from
3a5410f
to
0b15e0b
Compare
|
Some of the test failures you're seeing should be fixed by #241 |
alexmwu
commented
Jul 7, 2021
tpm2/test/tpm2_test.go
Outdated
| if err != nil { | ||
| t.Fatalf("GetCapability failed: %v", err) | ||
| } | ||
| if props[2].(TaggedProperty).Value <= 116 { |
There was a problem hiding this comment.
should use revision here
Some functions in tpm2 expect an encoded TPMT_SIGNATURE. Here, we add an Encode method on the Signature type to support these functions.
Add the ability to call TPM2_PolicySigned, and add PolicySigned test to verify correct behavior given different expiration values. Change TPM2_PolicySecret's signature to add the timeout, as described in Part 3 of the spec.
jkl73
reviewed
Aug 25, 2021
jkl73
approved these changes
Sep 3, 2021
josephlr
added a commit
to josephlr/go-tpm-tools
that referenced
this pull request
Feb 15, 2022
PolicySecret now returns three values (google/go-tpm#237) We never read the encoded value from Certify, so we are not affected by: google/go-tpm#235 Signed-off-by: Joe Richey <joerichey@google.com>
jessieqliu
pushed a commit
to google/go-tpm-tools
that referenced
this pull request
Mar 2, 2022
PolicySecret now returns three values (google/go-tpm#237) We never read the encoded value from Certify, so we are not affected by: google/go-tpm#235 Signed-off-by: Joe Richey <joerichey@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Split out ComputeAuthTimeout bug reproducer in #261